WordPress publication #8
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lewismoten/dreamy-tags#8
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Review what's needed to publish to WordPress, and setup updates/automatic updates.
Plugin Developer FAQ: https://developer.wordpress.org/plugins/wordpress-org/plugin-developer-faq/
Guidelines: https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/
Plugin Submission: https://wordpress.org/plugins/developers/add/
Install "Plugin Check" by Automatic before submitting.
https://lewismoten.com/wp-admin/tools.php?page=plugin-check&plugin=dreamy-tags%2Fdreamy-tags.php
The plugin submission page says reviews takes 1-10 days, and starts within 5 business days. The FAQ says 14 days to get approved of initial review.
Attempted to submit v1.0.50, but the account was disabled.
The WordPress.org account was unblocked on Tuesday, and the plugin was submitted. There was a false-positive detection on my profile data that I have since corrected. (Quick Tip: don't say your interests are "Stuff.") It will take 1-10 days to complete the review based on the documentation, with a goal of 5 business days.
Hi! To help with the WordPress publication, could you please share more details about the issue you're facing? Meanwhile, make sure your WordPress settings are correctly configured and the plugin is active. Let me know if you need any help!
This is my first plugin. The initial review stated there was a problem with ownership, which I had addressed. I just got another email for a few more things that I'm working through right now.
List of issues found
WordPress.org directory assets in the plugin code.
We've detected WordPress.org directory plugin asset files in your submission. Thanks for including them; However, these files (banners, icons, screenshots created for the directory plugin page) are not part of the plugin code and should not be included in your plugin zip file.
Plugin assets should be uploaded to the WordPress.org repository separately after the plugin is approved. This is done through the SVN access.
For more information about plugin assets and how to upload them, please refer to: How Your Plugin Assets Work.
From your plugin:
dreamy-tags/assets/screenshot-1.png
dreamy-tags/assets/banner-772x250.png
dreamy-tags/assets/screenshot-2.png
dreamy-tags/assets/icon-128x128.png
dreamy-tags/assets/icon-256x256.png
Use wp_enqueue commands
Your plugin is not correctly including JS and/or CSS. You should be using the built in functions for this:
When including JavaScript code you can use:
wp_register_script() and wp_enqueue_script() to add JavaScript code from a file.
wp_add_inline_script() to add inline JavaScript code to previous declared scripts.
When including CSS you can use:
wp_register_style() and wp_enqueue_style() to add CSS from a file.
wp_add_inline_style() to add inline CSS to previously declared CSS.
Note that as of WordPress 6.3, you can easily pass attributes like defer or async: https://make.wordpress.org/core/2023/07/14/registering-scripts-with-async-and-defer-attributes-in-wordpress-6-3/
Also, as of WordPress 5.7, you can pass other attributes by using this functions and filters: https://make.wordpress.org/core/2021/02/23/introducing-script-attributes-related-functions-in-wordpress-5-7/
If you're trying to enqueue on the admin pages you'll want to use the admin enqueues.
https://developer.wordpress.org/reference/hooks/admin_enqueue_scripts/
https://developer.wordpress.org/reference/hooks/admin_print_scripts/
https://developer.wordpress.org/reference/hooks/admin_print_styles/
Example(s) from your plugin:
dreamy-tags.php:103 echo '
ok, perfect!
Another review came back a few hours ago regarding generic naming. I've now standardized all functions, shortcode handlers, and the widget class to the
dreamy_tags_*prefix (including removing PascalCase from the main class per reviewer guidance). All previouslewismoten_dreamy_tags_*andLewisMotenDreamyTags*identifiers have been removed.Hoping this resolves the remaining naming issues.